AMIFamily Defaulting and Validation #1296
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 4c70160 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62030d58a54f7c0008a2e53c |
bwagner5
force-pushed
the
bottlerocket
branch
from
fd52b52 to
cf3f1a2
Compare
| OperatingSystemBottleRocket = "Bottlerocket" | ||
| OperatingSystemEKSOptimized = "EKSOptimized" | ||
| AMIFamilyBottlerocket = "Bottlerocket" | ||
| AMIFamilyEKSOptimized = "EKSOptimized" |
There was a problem hiding this comment.
Reminder to make this EKSOptimizedLinux
There was a problem hiding this comment.
Can't we just support Operating system separately and keep AMIFamily the actual family? So if AMIFamily was EKSOptimized but the pod requested Windows, we'd just give them windows EKS Optimized?
There was a problem hiding this comment.
This assumes a certain amount of parity between EKSOptimized. In general, I agree with you. IIRC, this was a request from @suket22.
bwagner5
force-pushed
the
bottlerocket
branch
from
de22561 to
f1cb013
Compare
| } | ||
| } else { | ||
| userData, err = p.getEKSOptimizedUserData(ctx, constraints, instanceTypes, additionalLabels) | ||
| userData := p.getEKSOptimizedUserData(ctx, constraints, instanceTypes, additionalLabels, caBundle) |
There was a problem hiding this comment.
totally minor, but if you factored this out into a function, you could use the same return pattern used in the ami logic and keep this core Get() function as simple as possible.
1. Issue, if available:
#923
2. Description of changes:
Some AMIFamily updates to support:
3. How was this change tested?
Tested in an EKS cluster using both Bottlerocket and EKS Optimized AMI
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.